[webkit-dev] Rename wtf/unicode/UTF8.h

[Konstantin Tokarev]

31.10.2018, 05:18, "Fujii Hironori" <fujii.hironori at gmail.com>:
> wtf/unicode/UTF8.h is conflicting with ICU header in MSVC builds. I'd like to rename wtf/unicode/UTF8.h to wtf/unicode/WTFUTF8.h.
> Any suggestion?

What about Unicode.h or UnicodeHelpers.h? UTF8.h deals with UTF16 as well

>
> Here is ICU's #include "unicode/utf8.h" which happens to include wtf/unicode/UTF8.h
> https://github.com/unicode-org/icu/blob/master/icu4c/source/common/unicode/utf.h#L217
>
> Here is MSVC quoted form #include behavior documented.
> https://msdn.microsoft.com/en-us/library/36k2cdd4.aspx
>
> Bug 189693 – [Win][Clang] warning: #include resolved using non-portable Microsoft search rules as: ..\..\Source\WTF\wtf/unicode/utf8.h
> https://bugs.webkit.org/show_bug.cgi?id=189693
>
> -- Fujii
>
> ,
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


-- 
Regards,
Konstantin