[webkit-dev] Remove HAVE_ACCESSIBILITY

Timothy Hatcher timothy at apple.com
Wed Nov 14 19:05:46 PST 2018


It wasn’t added for Tesla. But they did build with it disabled at the time I lasted worked on it. It was a frequent pain point to keep the build working when AX changes happened.

— Timothy Hatcher

> On Nov 14, 2018, at 5:29 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> 
> I think it was added for Telsa's private port. Probably not worth maintaining the flag if the maintenance cost is high but is it?
> 
> - R. Niwa
> 
>> On Wed, Nov 14, 2018 at 5:19 PM Fujii Hironori <fujii.hironori at gmail.com> wrote:
>> Hi webkit-dev,
>> 
>> It seems that all port defines HAVE_ACCESSIBILITY=1. Can I remove all code for !HAVE(ACCESSIBILITY)?
>> 
>> https://trac.webkit.org/browser/webkit/trunk/Source/WTF/wtf/Platform.h?rev=237992#L648
>> 
>>   #if PLATFORM(COCOA) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(WPE)
>>   #define HAVE_ACCESSIBILITY 1
>>   #endif
>> 
>> Bug 21802 – Rename HAVE_ACCESSIBILITY to ENABLE_ACCESSIBILITY
>> https://bugs.webkit.org/show_bug.cgi?id=21802
>> 
>> -- Fujii
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20181114/aae09f93/attachment.html>


More information about the webkit-dev mailing list