[webkit-dev] JavaScriptCore on Fuchsia

[Adrian Perez de Castro]

Hello,

(Just a quick note, below.)

On Wed, 27 Jun 2018 21:35:40 -0700, Adam Barth <abarth at webkit.org> wrote:
> On Wed, Jun 27, 2018 at 8:05 PM Adam Barth <abarth at webkit.org> wrote:
> >
> > Hi Yusuke,
> >
> > For some reason, your original email missed my inbox.
> >
> > On Wed, Jun 27, 2018 at 7:53 PM Michael Catanzaro <mcatanzaro at igalia.com> wrote:
> > > On Tue, Jun 26, 2018 at 6:49 PM, Yusuke SUZUKI <utatane.tea at gmail.com>
> > > wrote:
> > > > My suggestion is introducing Fushcia port, adding both
> > > > PLATFORM(FUSHCIA) and OS(FUSHCIA) ifdefs.
> > > > Use OS(FUSHCIA) when the change is b/c of Fushcia's APIs. And use
> > > > PLATFORM(FUSHCIA) to change
> > > > the policy of the released build (e.g. enabling / disabling FTL JIT
> > > > etc.).
> >
> > So far, I seem to be able to control those features on a build level
> > through CMake.
> >
> > > > By doing so, JSCOnly port also becomes available in Fushcia. And it
> > > > means that Fushcia port can benefit
> > > > from JSCOnly port's work for making WTF and JSC portable.
> >
> > Fuchsia appears to need to be a port in the sense of having an
> > OptionsFuchsia.cmake in order to set the target triple to
> > x86_64-unknown-fuchsia.  I didn't find any other uses of
> > CMAKE_CXX_COMPILER_TARGET in WebKit.  Is there some other mechanism
> > folks use to set the target triple (or maybe other folks aren't
> > crosscompiling using clang)?
> 
> I discovered CMAKE_TOOLCHAIN_FILE and figured out how to make this work:
> 
> https://bugs.webkit.org/show_bug.cgi?id=187133

Using CMAKE_TOOLCHAIN_FILE definitely should work, and if it ever breaks
we will want to fix things. This is what many cross-compilation systems
(example: Buildroot) are using for building the GTK+ and WPE ports, which
means we'll notice if any issue is introduced [1].

> > > I wonder if PLATFORM(FUSHCIA) is even needed? Maybe OS(FUSHCIA) would
> > > suffice? Then instead of a separate Fushcia port, we would just have
> > > the existing JSCOnly port running on Fuschia.
> >
> > That sounds like a good approach to start with.  If we run into
> > trouble, we might need to adjust.

As long as having only OS(FUCHSIA) satisfies your needs, I also think it
is simpler to avoid PLATFORM(FUCHSIA) and reusing the JSCOnly port for now.

Cheers,

 Adrián

---
[1] I'm subscribed to Buildroot's autobuilder (http://autobuild.buildroot.net)
    for the “webkitgtk” package, which has been handy to fix quite some build
	issues in the past :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20180628/907d42bf/attachment.bin>