[webkit-dev] Buildbot upgrade on build.webkit.org

Aakash Jain aakash_jain at apple.com
Mon Jan 8 13:33:21 PST 2018


Hi Everyone,

I filed the Buildbot bug regarding Waterfall view not displaying steps information by default: https://github.com/buildbot/buildbot/issues/3884 "Waterfall view should display steps information without hovering over".

I got the response that the issue with displaying all the steps information by default in waterfall view is that it would require a lot of API calls, and so it wouldn't be scalable.

Can you guys look at the new console and grid view to see if they can serve as an alternative?
e.g.:
https://nine.buildbot.net/#/console
https://nine.buildbot.net/#/grid


Here is the complete response:

"I agree the new waterfall is not very useful.
It is not really a problem of UI change, it is rather a problem of the number of rest API needed to get the information needed. In order to display the old waterfall, you need to get the whole details for every builds (steps, logs), that would be dozens of REST api calls, which would take a lot of time.

The old waterfall was not very scalable too, on my old buildbot eight at work, we disabled it, because it was stalling the the master for 10s every time one user would look at it.

The question you have to ask your users is what is the information that is really needed.
Maybe we can load the steps only for the failed builds?

We find the console_view and grid_view much more useful? They don't have details of which step failed, but the details of which builder is failing sorted by change, and usually people have been doing one builder per "kind of test"

You can see the example here, and the categorisation of builders, which I think could be quite useful as a replacement for https://build.webkit.org/waterfall

https://nine.buildbot.net/#/console

What user might request is probably the reason for failure, which can be done without having to fetch more information (by using the build results_string)
In the current version you can still click on a build, and have all the information for that build, including tail log of the failing steps (without changing web page)."


-Aakash


> On Dec 13, 2017, at 6:51 PM, Aakash Jain <aakash_jain at apple.com> wrote:
> 
> 
> 
>> On Dec 11, 2017, at 1:10 AM, Konstantin Tokarev <annulen at yandex.ru <mailto:annulen at yandex.ru>> wrote:
>> 
>> 
>> 
>> 11.12.2017, 02:49, "Carlos Alberto Lopez Perez" <clopez at igalia.com <mailto:clopez at igalia.com>>:
>>> On 07/12/17 21:47, Aakash Jain wrote:
>>>>  For people using build.webkit.org <http://build.webkit.org/> <http://build.webkit.org/ <http://build.webkit.org/>>, I would
>>>>  like to know what pages you use most of the time (e.g.: builder page,
>>>>  console view etc.) and what are your primary use-cases (purpose to
>>>>  visit build.webkit.org <http://build.webkit.org/> <http://build.webkit.org/ <http://build.webkit.org/>>). Also if you have
>>>>  any feedback/concern about new Buildbot please let me know.
>>> 
>>> I use 99% of the time the waterfall view, and I think the new waterfall
>>> view of buildbot 9 is a step back in terms of usefulness.
>>> 
>>> More details on about why I think this here:
>>> https://bugs.webkit.org/show_bug.cgi?id=175056#c1 <https://bugs.webkit.org/show_bug.cgi?id=175056#c1>
>> 
>> I also use waterfall 99% of time, and new waterfall totally sucks.
>> 
>> I wonder if it's possible to get rid of stupid sidebar, if not it's a complete
>> disaster.
> 
> The sidebar can be collapsed by clicking on the pin button on top (<pin.png>).
> 
> Are there any other suggestions for changes we could try in new buildbot waterfall view to make it suitable?
> 
> Since we are on a very old version of buildbot, at some point we would have to upgrade. It would be nice if we could identify changes which can be made either to buildbot or to our workflow to better suit our requirements. We can also consider passing on the feedback directly to Buildbot by filing bugs at https://github.com/buildbot/buildbot/issues <https://github.com/buildbot/buildbot/issues>, so that Buildbot can fix them.
> 
> Thanks
> Aakash
> 
>> 
>>> 
>>> ,
>>> 
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
>> -- 
>> Regards,
>> Konstantin
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20180108/4dc21516/attachment.html>


More information about the webkit-dev mailing list