[webkit-dev] OWNERS policy
mjs at apple.com
Thu Feb 22 00:19:57 PST 2018
> On Feb 21, 2018, at 11:06 PM, Carlos Garcia Campos <carlosgc at webkit.org> wrote:
> El mié, 21-02-2018 a las 13:49 -0800, Ryosuke Niwa escribió:
>> If there was any confusion, WebKit2 Owner's policy is still active
>> and in effect.
> And maybe it's time to get rid of it? I never liked the idea, but I
> have to admit it made sense at the time it was done. The WebKit2
> development was on fire and wk2 developers couldn't spend time dealing
> with build failures on other ports that would slow down the development
> pace. Nowadays, WebKit2 doesn't really exist, it's WebKit again, and
> the old WebKit is considered legacy. We no longer need a policy.
> Removing the policy doesn't mean not owners will do any kind of
> changes, I think we all know when to ask other developers for a second
> review or approval. The same we have always done in other components
> jsc, WebCore, WTF that don't have an owners policy.
Some of us at Apple have discussed changing it, but nothing to announce yet.
I do think we have problems with people reviewing things that they aren't fully qualified to review, but that happens throughout the whole tree. So that logically leads to the conclusion of either no OWNERS or OWNERS everywhere.
>> In the case you aren't sure of the right reviewer, you can send a
>> bulk email to all of us. I get cc'ed on every WebKit bug with Mac
>> EWS/CQ failure, and as such, I ignore all WebKit bugs I'm cc'ed
>> unless the bug title is of my interest.
>> - R. Niwa
>> On Wed, Feb 21, 2018 at 1:27 PM, youenn fablet <youennf at gmail.com>
>>> Hi Don,
>>> I am not sure there is a well defined policy.
>>> If we want to continue with owners, it would indeed be good to make
>>> it clearer and more functional.
>>> Here is my current understanding.
>>> The multi-process architecture is now well in place so things like
>>> updating IPC encoders/decoders might no longer require a dedicated
>>> owner scrutiny.
>>> Exposing the right WK2 APIs is more sensitive on the other hand.
>>> Le mer. 21 févr. 2018 à 12:52, <Don.Olmstead at sony.com> a écrit :
>>>> Hi WebKittens,
>>>> As you know we're working on getting WinCairo running on modern
>>>> WebKit. We're working through a backlog of patches we have to
>>>> upstream and are sometimes running into issues where we can't
>>>> find reviewers for our code.
>>>> Here are some bugs with attachments that have been hanging out
>>>> for over 5 days.
>>>> One thing we're unclear on is the OWNERS policy. The list itself
>>>> is pretty small and has no guidance on who might be the right
>>>> person(s) to assign a bug to when touching shared code. It feels
>>>> like we're just guessing on reviewers which doesn't seem like it
>>>> helps anything move along.
>>>> There also seem to be commits that were reviewed by non-owners
>>>> that are touching common code. We're not sure if unfamiliarity
>>>> with Windows might prevent some owners from looking over a patch
>>>> as we move further along in our implementation.
>>>> Basically we'd like to get some clarification here so we can keep
>>>> landing patches for modern WebKit on Windows.
>>>> Sony WebKit Team
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
More information about the webkit-dev