[webkit-dev] WebCorePrefix.h vs. config.h

[Fujii Hironori]

On Wed, Dec 12, 2018 at 7:07 AM Darin Adler <darin at apple.com> wrote:

> > On Dec 9, 2018, at 10:34 PM, Fujii Hironori <fujii.hironori at gmail.com>
> wrote:
> >
> > MSVC has /FI option.
> >
> >   /FI (Name Forced Include File) | Microsoft Docs
> >
> https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017
> >
> > Unfortunately, it seems that MSVC's precompiled header needs to be
> included explicitly.
> >
> >   /Yu (Use Precompiled Header File) | Microsoft Docs
> >
> https://docs.microsoft.com/en-us/cpp/build/reference/yu-use-precompiled-header-file?view=vs-2017
>
> So this seems like the main potential obstacle. We can force an include of
> a prefix header, or precompile a header, but not both, with the Microsoft
> compiler.
>

It was just my misunderstanding. WebKit Windows ports are already using
both /Yu and /FI.
https://trac.webkit.org/browser/webkit/trunk/Source/cmake/WebKitMacros.cmake?rev=229282#L100

 It seems that WebKit can stop including config.h in all source fils.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20181212/479aa1aa/attachment.html>