[webkit-dev] WebCorePrefix.h vs. config.h

[Don.Olmstead at sony.com]

There was some work done by aperez to try and enable precompiled headers on all platforms at https://bugs.webkit.org/show_bug.cgi?id=139438 which never landed. I always thought of WebCorePrefix.h as a precompiled headers sort of optimization.

Last time I checked though there was definitely an issue with how up to date things were in that file and statement that “the project should be able to build without this header, although we rarely test that.” Is definitely false.

From: webkit-dev <webkit-dev-bounces at lists.webkit.org> On Behalf Of Fujii Hironori
Sent: Sunday, December 9, 2018 10:35 PM
To: Webkit Development List <webkit-dev at lists.webkit.org>
Subject: Re: [webkit-dev] WebCorePrefix.h vs. config.h


On Sun, Dec 9, 2018 at 8:22 AM Darin Adler <darin at apple.com<mailto:darin at apple.com>> wrote:
Best would be to eliminate “config.h”: Change “config.h” into an empty file first, then remove all “config.h” includes, and then remove the file. But to do that, we need to make sure every build system for WebKit supports prefix headers. I don’t know how close to that we are. Maybe close? How can we quickly find out?

 GCC and Clang support '-include <file>' option.

  https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html<https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html>
  https://clang.llvm.org/docs/ClangCommandLineReference.html<https://clang.llvm.org/docs/ClangCommandLineReference.html>

GTK and WPE ports are using it only in WK2 since r163032.

  https://trac.webkit.org/changeset/163032<https://trac.webkit.org/changeset/163032>

MSVC has /FI option.

  /FI (Name Forced Include File) | Microsoft Docs
  https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017<https://docs.microsoft.com/en-us/cpp/build/reference/fi-name-forced-include-file?view=vs-2017>

Unfortunately, it seems that MSVC's precompiled header needs to be included explicitly.

  /Yu (Use Precompiled Header File) | Microsoft Docs
  https://docs.microsoft.com/en-us/cpp/build/reference/yu-use-precompiled-header-file?view=vs-2017<https://docs.microsoft.com/en-us/cpp/build/reference/yu-use-precompiled-header-file?view=vs-2017>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20181210/94ebeb32/attachment.html>