[webkit-dev] WebKit Commit Queue blocked by build errors in ToT

[Chris Fleizach]

Hi

Looks like Commit Queue is blocked on processing patches because of a build failure that's been there for a day

--------------------------------------
https://webkit-queues.webkit.org/results/10296999
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:27:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:229:40: error: unknown type name 'SafeBrowsingWarning'; did you mean 'WKSafeBrowsingWarning'?
    void showSafeBrowsingWarning(const SafeBrowsingWarning&, CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&&);
                                       ^~~~~~~~~~~~~~~~~~~
                                       WKSafeBrowsingWarning
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:56:12: note: 'WKSafeBrowsingWarning' declared here
OBJC_CLASS WKSafeBrowsingWarning;
           ^
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1619:19: error: out-of-line definition of 'showSafeBrowsingWarning' does not match any declaration in 'WebKit::WebViewImpl'
void WebViewImpl::showSafeBrowsingWarning(const SafeBrowsingWarning& warning, CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&& completionHandler)
                  ^~~~~~~~~~~~~~~~~~~~~~~
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2801:22: error: instance method '-dismiss' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
        [_shareSheet dismiss];
                     ^~~~~~~
-----------------

Filed a bug to track: https://bugs.webkit.org/show_bug.cgi?id=192479

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20181206/40404b19/attachment.html>