[webkit-dev] Unified sources build errors when adding new source files

Javier Fernandez jfernandez at igalia.com
Tue Nov 21 06:54:25 PST 2017


The patch at https://bugs.webkit.org/show_bug.cgi?id=179633 it's just a
refactoring of the Grid Layout code which defines a new namespace with a
bunch of Grid related utility functions, only used from the RenderGrid
and GridTrackSizingAlgorithm classes. The patch adds a new entry to the
WebCore/Source.txt, for the file GridLayoutFunctions.cpp.

It builds perfectly with the no-unify tag, but I produces totally
unrelated errors when using the unified building. I wonder whether my
patch could make those errors arise because of altering the building
units (8 files, as far as I know) when adding the mentioned new entry to
the WebCore/Source.txt file.


More information about the webkit-dev mailing list