[webkit-dev] Where do we put WPT tests to be exported

youenn fablet youennf at gmail.com
Mon May 15 21:08:46 PDT 2017


I see two main cases:
- Writer of the patch is making sure to upstream WPT test changes at WebKit
landing time. It is ok to make the changes directly in
LayoutTests/imported/w3c/web-platform-tests/
- Writer plans to upstream WPT test changes at some point but wants more
time. It is better to develop the tests in LayoutTests/http/wpt and then
migrate them later on.

I would start with an experimental phase with some of us making direct
changes in LayoutTests/imported/w3c/web-platform-tests/.
When we are happy with the tools and think the risk for issues is low
enough (or when the bots can handle most of it for us), hacking
LayoutTests/imported/w3c/web-platform-tests/ could be the default.

Le lun. 15 mai 2017 à 21:02, Ryosuke Niwa <rniwa at webkit.org> a écrit :

> Hi all,
>
> Youenn is working on a patch to automatically create a GitHub PR to
> export tests from a WebKit patch which includes changes to
> web-platform-tests [1].
>
> That raises a question as to where we should put new tests or modified
> tests intended to be exported to web-platform-tests from WebKit.
>
> I think the most obvious option is to use
> LayoutTests/imported/w3c/web-platform-tests/.  However, in the other
> thread about adopting testharness.js (titled Another WPT bite), Maciej
> briefly expressed the preference for creating a new directory:
> https://lists.webkit.org/pipermail/webkit-dev/2017-May/029022.html
>
> Do other people have strong opinions about this?
>
> - R. Niwa
>
> [1] https://bugs.webkit.org/show_bug.cgi?id=169462
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20170516/ec23c0cf/attachment.html>


More information about the webkit-dev mailing list