[webkit-dev] Clang tidy
mjs at apple.com
Wed May 3 20:31:07 PDT 2017
> On May 3, 2017, at 6:31 PM, Olmstead, Don <Don.Olmstead at sony.com> wrote:
> I took some time today to see how clang-tidy can be run on WebKit code and openedhttps://bugs.webkit.org/show_bug.cgi?id=171632 <https://bugs.webkit.org/show_bug.cgi?id=171632> with some examples on how to run things. I also attached some output from the modernizer fixes that can be applied.
> I was thinking of running any code we move from WebCore/platform through clang-tidy during the process of moving it to PAL. Documentation for the checks can be found at http://clang.llvm.org/extra/clang-tidy/checks/list.html <http://clang.llvm.org/extra/clang-tidy/checks/list.html>if anyone wants to take a look at what should potentially be run.
I think moving code should be done with the bare minimum changes needed to do the move (file paths, etc). Any code cleanup script should be done separately. Any change can break things (though we hope both moving files and running clang-tidy would have no behavioral effect). Therefore it's best not to mix unrelated changes, so if a regression occurs, it's easier to see what caused it.
Probably there should also be a discussion of whether we want these particular changes. People tend to dislike churn, and we'd also need to make sure the newer style works on all toolchains that people use, and that stylistically we like #include <cwhatever> in place of #include <whatever.h> and using in place of typedef. I don't think we have style rules calling for those things, so it would be jumping the gun a bit to start applying them. This is an additional reason to separate style changes from moving code to PAL (which I believe has been discussed and is not controversial).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev