[webkit-dev] WebCore/platform standalone library

Myles C. Maxfield mmaxfield at apple.com
Wed Jan 11 10:36:03 PST 2017



On Jan 10, 2017, at 9:28 PM, Darin Adler <darin at apple.com> wrote:

>> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield <mmaxfield at apple.com> wrote:
>> 
>> We opted for WebCore to include files using “#include <PAL/Foo.h>” instead of just including Foo.h.
> 
> Will this work without ForwardingHeaders on macOS and iOS?

I think this requires more investigation to answer. 

> 
> Given that WTF chose <wtf/xxx.h>, what is the reasoning for PAL choosing the all capital <PAL/xxx.h>?

Beauty. Do you think this was a bad call?

> 
>> Similarly, we are putting symbols inside the PAL namespace, which is a child of the WebCore namespace. Therefore, inside WebCore, you use PAL things by specifying “PAL::Foo”.
> 
> Given that WebCore is built on top of PAL, it seems a little strange to put PAL “inside” WebCore, but I guess OK.

Yeah, this was driven by the decision to make it a target rather than a project. Putting a target of a project outside the project itself seems worse than putting a dependency inside the project.

> 
> — Darin


More information about the webkit-dev mailing list