[webkit-dev] !!Tests for equality comparison

[JF Bastien]

> On Apr 27, 2017, at 16:30, Geoffrey Garen <ggaren at apple.com> wrote:
> 
> I’ve never really liked this style rule, and I’ve always felt like it snuck into the style document without much discussion.

It date from 2009: https://bugs.webkit.org/show_bug.cgi?id=27333 <https://bugs.webkit.org/show_bug.cgi?id=27333>


> Even so, I usually tolerate it.
> 
> Geoff
> 

> On Apr 27, 2017, at 16:10, Filip Pizlo <fpizlo at apple.com> wrote:
> 
> I think that this aspect of the style - its implications for ints - was deliberate.
> 
> The code uses the !int style in so many places that this style change would be a lot of churn for little benefit.  I eventually got used to this style, and now it feels pretty natural.

I’m not suggesting we replace existing code. Just that we allow it for now on.

> -Filip

>> On Apr 27, 2017, at 4:06 PM, JF Bastien <jfbastien at apple.com <mailto:jfbastien at apple.com>> wrote:
>> 
>> Hello C++ fans!
>> 
>> The C++ style check currently say:
>> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons
>> 
>> I totally agree for booleans and pointers… but not for integers. I know it’s pretty much the same thing, but I it takes me slightly longer to process code like this:
>> 
>> int numTestsForEqualityComparison = 0:
>> // Count ‘em!
>> // …
>> if (!numTestsForEqualityComparison)
>>   printf(“Good job!”);
>> 
>> I read it as “if not number of tests for equality comparison”. That's weird. It takes me every slightly longer to think about, and I’ve gotten it wrong a bunch of times already. I’m not trying to check for “notness", I’m trying to say “if there were zero tests for equality comparison”, a.k.a.:
>> 
>> if (numTestsForEqualityComparison == 0)
>>   printf(“Good job!”);
>> 
>> So how about the C++ style let me just say that? I’m not suggesting we advise using that style for integers everywhere, I’m just saying it should be acceptable to check zero/non-zero using equality comparison.
>> 
>> 
>> !!Thanks (i.e. many thanks),
>> 
>> JF
>> 
>> p.s.: With you I am, fans of Yoda comparison, but for another day this will be.
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20170427/e2cbcbf0/attachment.html>