[webkit-dev] Exporting WPT tests
youennf at gmail.com
Sun Apr 23 23:02:40 PDT 2017
After talking with some WebKittens, I'd like to discuss the process of
upstreaming WPT tests from WebKit. Here is my take of it.
WPT tests need a review before being merged.
This review can be done in WPT GitHub at PR time.
This review can also be done as part of the usual WebKit review flow.
As done by other browser teams, a test that is reviewed in WebKit bugzilla
and landed in WebKit can be readily merged into WPT without additional
review (although additional review is always great!).
The only constraint I know of is that the test does not give flaky tests
from WPT Chrome/Firefox bots.
We do not have yet the tooling to automate the creation of a WPT GitHub PR
from a WebKit patch that lands.
In the meantime, for those of us planning to contribute to WPT, it might
make sense to start using a consistent flow.
How about marking explicitly the PRs as coming from WebKit in the title,
with the related bugzilla URL in the comment?
Patch at https://bugs.webkit.org/show_bug.cgi?id=169462 might be handy for
When done so, how about allowing any WebKitten with WPT repository merge
access to merge those PRs without further review?
It might (and did) happen that a proposed test is conforming to the spec
but the spec is expected to change at some point.
I don't think we should refrain from landing such test in WPT.
A test exercising the currently described behavior is a good thing anyway.
It might actually ease the job of those who will later need to provide a
test that will cover the spec change.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev