[webkit-dev] Image decoding refactoring...

Said Abou-Hallawa sabouhallawa at apple.com
Sat Sep 10 17:34:06 PDT 2016

Can someone on the GTK or the EFL ports review this patch: https://bugs.webkit.org/attachment.cgi?id=288475&action=review? <https://bugs.webkit.org/attachment.cgi?id=288475&action=review?> It is a work towards the asynchronous image decoding task: https://bugs.webkit.org/show_bug.cgi?id=155322 <https://bugs.webkit.org/show_bug.cgi?id=155322>. The goal is have one declaration for the class ImageDecoder instead of having two declarations in ImageDecoder.h and ImageDecoderCG.h. And also to replace FrameData in BitmapImage.h and ImageFrame in ImageDecoder.h by one class/struct. Currently for non CG ports the image frame data is cached twice: one in ImageDecoder object and the other in BitmapImage object. If ImageDecoder and BitmapImage use the same class/struct for the image frame, no need to cache it twice.

Also I could get this patch to compile but I could not verify it passes the layout tests. Is there a way to run the layout tests on the GTK/EFL EWS? I do not want to land the patch and then know that the layout tests did not pass and I have to roll the patch out. Any help in verifying the layout tests is very appreciated.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20160910/ed1eed0b/attachment.html>

More information about the webkit-dev mailing list