[webkit-dev] Is someone going to fix Windows EWS?
bfulgham at apple.com
Wed Mar 30 09:47:20 PDT 2016
This is happening because “Font.h” is referring to “<WebCore/CoreGraphicsSPI.h>”, which doesn’t always exist on Windows at the time the file is compiled. The CoreGraphicsSPI.h file lives in “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal ‘#include “CoreGraphicsSPI.h”. It’s only after a post-build step copies the file to “DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h” that the ‘#include <WebCore/CoreGraphicsSPI.h>” form works.
When a non-clean build is performed, this is fine, so EWS probably works properly most of the time. But if something prompts it to clean the build output, the file doesn’t exist and the build fails, improperly blaming the current patch.
I’ll talk to Alex about the copy phase of these headers and see if we can get this into proper position earlier.
> On Mar 30, 2016, at 9:28 AM, Alexey Proskuryakov <aproskuryakov at gmail.com> wrote:
> They fail like this: https://webkit-queues.webkit.org/queue-status/win-ews/bots/ews202https://webkit-queues.webkit.org/results/1069527
> c:\cygwin\home\buildbot\webkit\source\webcore\platform\graphics\Font.h(57): fatal error C1083: Cannot open include file: 'WebCore/CoreGraphicsSPI.h': No such file or directory (compiling source file C:\cygwin\home\buildbot\WebKit\Source\WebCore\DerivedSources.cpp) [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreDerivedSources.vcxproj]
> It's quite surprising that the build passes after rolling out a patch, thus making EWS think that the patch is to blame.
> - Alexey
>> 30 марта 2016 г., в 9:20, Brent Fulgham <bfulgham at apple.com> написал(а):
>> Aside from ews206 being offline for some reason, all bot seem to be running without any errors.
>> Can you point me at a couple of the patches you were looking at? I spot-checked a couple in the Review Queue and they seemed to be failing for legitimate problems with the patches.
>>> On Mar 30, 2016, at 9:04 AM, Brent Fulgham <bfulgham at apple.com> wrote:
>>> Looking now.
>>>> On Mar 30, 2016, at 9:02 AM, Darin Adler <darin at apple.com> wrote:
>>>> Every patch I look at has a red bubble for Windows on EWS. Is someone planning on fixing this?
>>>> — Darin
>>>> webkit-dev mailing list
>>>> webkit-dev at lists.webkit.org
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
More information about the webkit-dev