[webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

Darin Adler darin at apple.com
Fri Mar 4 14:04:08 PST 2016


> On Mar 4, 2016, at 10:51 AM, Michael Catanzaro <mcatanzaro at igalia.com> wrote:
> 
> We had a GTK port bug caused by a missing virtual destructor recently.

Oh no!

> GCC and Clang have warnings for this, which I think should be enabled, but apparently were not or somehow didn't work.

I’d like to learn more about this. Are the relevant warnings on for all the WebKit project’s compilers, ports, and build systems?

— Darin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20160304/e2cda0e3/attachment.html>


More information about the webkit-dev mailing list