[webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

Brent Fulgham bfulgham at apple.com
Thu Mar 3 11:24:26 PST 2016


+1. I am in favor of this as well!

-Brent

> On Mar 3, 2016, at 11:23 AM, Saam barati <sbarati at apple.com> wrote:
> 
> +1.
> I like how “override” only reads.
> 
> Saam
> 
>> On Mar 3, 2016, at 9:54 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> 
>> I think "virtual" + "override" is more of a historical artifact than
>> the preferred style because we used to have OVERRIDE macro before all
>> compilers supported C++11.  I think we should just use only "override"
>> going forward.
>> - R. Niwa
>> 
>> 
>> On Thu, Mar 3, 2016 at 9:38 AM, Darin Adler <darin at apple.com> wrote:
>>> Antti proposed using only “override” a while back since it’s less verbose and still unambiguous. I don’t think we reached consensus on which style to prefer for the project, though.
>>> 
>>> — Darin
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev



More information about the webkit-dev mailing list