[webkit-dev] Proposal: Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC)

[Osztrogonác Csaba]

Hi,

ENABLE(SUBPIXEL_LAYOUT) guard was removed and ENABLE(SATURATED_LAYOUT_ARITHMETIC)
is enabled on all ports more than a year ago. I don't know any issue related to it.

I'd like to propose to remove the ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards too.
https://bugs.webkit.org/show_bug.cgi?id=150972

Any objection?

br,
Ossy

former thread - [webkit-dev] Proposal: Remove ENABLE(SUBPIXEL_LAYOUT)
On 2014-08-18 22:30, Zalan Bujtas wrote:
> Hi,
>
> Quote for from bug #124234
> "Since the SATURATED_LAYOUT_ARITHMETIC flag makes no sense without SUBPIXEL_LAYOUT, actually there is an assertion preventing this, it seems that the most sensible action is to merge the SATURATED_LAYOUT_ARITHMETIC logic into the SUBPIXEL_LAYOUT, and eventually removing it.”
> Makes sense. I might just remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) too (instead of just enable it by default).
>
> Zalan.
>
> On Aug 18, 2014, at 12:47 PM, Javier Fernandez <jfernandez at igalia.com> wrote:
>
>> Hi,
>>
>> On 08/18/2014 08:14 PM, Zalan Bujtas wrote:
>>> Hi Everyone, I’d like to propose removing ENABLE(SUBPIXEL_LAYOUT), as
>>> every port has it enabled. As part of this activity, I am planning to
>>> enable SATURATED_LAYOUT_ARITHMETIC by default. Thanks, Zalan.
>>
>> I've already opened a bug to address this issue, but unfortunately,
>> didn't find the time to complete the task. See
>> https://bugs.webkit.org/show_bug.cgi?id=124234 for details.
>>
>> --
>> javi