[webkit-dev] Unused parameter warnings / errors / warning fixes

Osztrogonác Csaba oszi at inf.u-szeged.hu
Mon Jan 26 06:40:04 PST 2015

Hi all,

I noticed many patches to fix newly introduced unused
parameter warnings on GTK and EFL ports nowadays.
(ToT EFL WebKit is warning free right now.)

CMake ports now handle unused parameters as warnings, not build
errors everywhere. (-Werror and -Wno-error=unused-parameter )
Mac port handles them as build errors, except in WebKit, WebKit2
and WebInspectorUI, where it is disabled (-Wno-unused-parameter)
WebInspectorUI  is warning free now, but there are zillion warnings
in WebKit and Webkit2.

It would be great if we can handle unused parameters in the same way:
- treat them as errors
- treat them as warnings and fix sometimes
- disable them and don't try to fix again and again
   (and maybe remove zillion UNUSED_PARAM warning fixes )

I played a little bit to see if it is possible to get rid these warnings
easily on Mac too and then handle the new ones as build failres:

But I'm not sure if treating unused parameters as errors would be good
idea, because many of them depend on different feature ifdef guards
and it might cause more frequent build failures. Maybe disabling them
would be better.

Ideas, opinions, concerns and suggestions are welcome.


More information about the webkit-dev mailing list