[webkit-dev] MathML layout refactor proposal

Javier Fernandez jfernandez at igalia.com
Mon Dec 14 12:47:39 PST 2015

Hash: SHA1


On 12/14/2015 08:03 PM, Frédéric WANG wrote:
> Le 14/12/2015 19:39, Zalan Bujtas a écrit :
>> It’s great to hear that MathML is getting some proper cleanup. I 
>> think the proposal sounds good and I am looking forward to the 
>> patches.
>> Minor observation: I noticed that, since MathML block is no 
>> longer a flexbox, but it still needs some of the flexbox 
>> functionality, the following pattern has been introduced to the 
>> generic renderbox/block code. -    if
>> (parent()->isFlexibleBox()) { +    if (parent()->isFlexibleBox()
>> || parent()->isRenderMathMLBlock()) { I just wish there was
>> another way to handle this.
>> Zalan.
> Alex will correct me if I'm wrong, but I think the changes in 
> RenderBox are just a temporary solution to avoid breaking tests 
> while we continue to rewrite the MathML layout code. Hopefully, 
> these won't be needed anymore when we are done.

Fred is totally right. That's just legacy code from the old Flexbox
functionality, which we had to adopt temporary in order to keep
passing the current layout tests. We won't need it anymore in the new
layout logic.
Version: GnuPG v2


More information about the webkit-dev mailing list