[webkit-dev] Proposal: Remove TextureMapperImageBuffer

[Gwang Yoon Hwang]

Hi all,

After llvmpipe(Mesa) is blacklisted in EFL (after bumped up EFL),
I couldn’t fix regressions related with TextureMapper and CoordinatedGraphics in EFL port.

I agree to remove TextureMapperImageBuffer and disable accelerated compositing in EFL port
for awhile.

Gyuyoung, could you find out a reason why EFL blacklisted llvmpipe for OpenGL(ES) backend?

Regards,
Yoon

> On Apr 24, 2015, at 11:04 AM, Gyuyoung Kim <gyuyoung.kim at webkit.org> wrote:
> 
> Hello Martin,
> 
> I and Ossy have maintained EFL bots and EWS so far. Recently WebGL feature has been broken on EFL port since we bumped EFL version to 1.11.2. That's why we skipped to run WebGL tests on EFL layout test. - https://trac.webkit.org/changeset/167345.
> 
> But, unfortunately I'm not sure when we can fix it for EFL port. Thus I agree to disable the accelerated compositing and skip related tests
> in order not to block your work.
> 
> If any EFL folks know better solution for now, please let us know.
> 
> Gyuyoung.
> 
> On Fri, Apr 24, 2015 at 5:38 AM, Martin Robinson <mrobinson at webkit.org> wrote:
> I'd love to coordinate with whoever is running the EFL bots to get a
> configuration that can run these tests with OpenGL. The WebKitGTK+
> bots use llvmpipe to make this happen.
> 
> --Martin
> 
> On Thu, Apr 23, 2015 at 1:15 PM, Benjamin Poulain <benjamin at webkit.org> wrote:
> > It seems undesirable to use a completely different stack for testing and for
> > shipping.
> >
> > Wouldn't it be possible to use Mesa on the EFL bots?
> >
> >
> > On 4/23/15 12:10 PM, Martin Robinson wrote:
> >>
> >> A slight update on this issue. It's already been attempted here:
> >> https://bugs.webkit.org/show_bug.cgi?id=143561
> >>
> >> The issue is that WebKitEFL is using the TextureMapperImageBuffer to
> >> run tests on their bots, because the EFL bots don't support OpenGL
> >> tests. My suggestion is that we disable accelerated compositing
> >> completely for WebKitEFL (if possible) and skip those tests. Once the
> >> bots have the ability to run tests that use OpenGL, we can re-enable
> >> that code path for WebKitEFL.
> >>
> >> --Martin
> >>
> >> On Thu, Apr 23, 2015 at 11:12 AM, Martin Robinson <mrobinson at webkit.org>
> >> wrote:
> >>>
> >>> Background: There currently exists a fallback TextureMapper
> >>> implementation that does not use OpenGL to composite and project
> >>> layers, but instead relies on 2D rasterization. This does not work
> >>> correctly for Cairo, since Cairo only supports affine transformations.
> >>> I believe this path is only used by GTK+ (and perhaps WinCairo) now.
> >>>
> >>> Proposal: I would like to remove TextureMapperImageBuffer and make
> >>> TextureMapperGL the only implementation of TextureMapper. Not only
> >>> will this simplify the code, it will remove a build flag
> >>> (TEXTURE_MAPPER_GL). The current path isn't (or really shouldn't) be
> >>> enabled by default.
> >>>
> >>> Please speak up if you are opposed. :)
> >>>
> >>> --Martin
> >>
> >> _______________________________________________
> >> webkit-dev mailing list
> >> webkit-dev at lists.webkit.org
> >> https://lists.webkit.org/mailman/listinfo/webkit-dev
> >>
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20150424/6b0d7529/attachment.sig>