[webkit-dev] Proposal: Remove ENABLE(SVG)

[Osztrogonác Csaba]

Hi,

+1 for removing ENABLE(SVG) guards.

The --no-svg build is broken now, and the change broke it is
11 months old change - https://trac.webkit.org/changeset/145450, so
--no-svg build isn't maintained at all and nobody can use it on trunk.

Let's go forward and remove the guards:
https://bugs.webkit.org/show_bug.cgi?id=127991
(I started to prepare a patch, not yet finished.)

Ossy

no-svg build log:
------------------
In file included from 
/Users/oszi/WebKit/Source/WebCore/css/BasicShapeFunctions.cpp:35:
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2670:27: 
error: use of undeclared identifier 'CSSValueAlphabetic'
         m_value.valueID = CSSValueAlphabetic;
                           ^
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2687:10: 
error: use of undeclared identifier 'CSSValueAlphabetic'
     case CSSValueAlphabetic:
          ^
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4300:27: 
error: use of undeclared identifier 'CSSValueAlphabetic'
         m_value.valueID = CSSValueAlphabetic;
                           ^
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4334:10: 
error: use of undeclared identifier 'CSSValueAlphabetic'
     case CSSValueAlphabetic:
          ^
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4846:27: 
error: use of undeclared identifier 'CSSValueAlphabetic'
         m_value.valueID = CSSValueAlphabetic;
                           ^
/Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4872:10: 
error: use of undeclared identifier 'CSSValueAlphabetic'
     case CSSValueAlphabetic:
          ^
6 errors generated.
----------------------------------------------------------------------

On 01/29/2014 01:13 AM, Sam Weinig wrote:
> Hi Everyone,
>
> While we are discussing removing #ifdefs that everyone has enabled, I’d like to propose removing ENABLE(SVG), as every port has SVG enabled.  The only argument I have heard for keeping it around is to keep a “minimal build” working, but I don’t think the clutter of the #ifdefs is worth that.
>
> -Sam