[webkit-dev] On web-exposing features disabled at runtime

Benjamin Poulain benjamin at webkit.org
Tue Feb 11 10:25:41 PST 2014


On 2/11/14, 9:26 AM, Maciej Stachowiak wrote:
> On Feb 10, 2014, at 1:38 PM, Benjamin Poulain <benjamin at webkit.org>
> wrote:
>> 
>> Can't we add a compile time flag instead? The chromium patch you
>> linked is inelegant and it touches some hot paths.
>> 
>> Another advantage of compile time flag is Andreas eventually notice
>> when they become useless and remove all the unnecessary cruft ;)
> 
> I think on the whole, runtime flags are a better way to do things.
> They allow features to get much better testing before they are turned
> on by default, among other things by enabling regression tests to
> run. They also make it more likely that both configurations keep
> compiling, regardless of which is default.

Why not enabling the feature entirely on trunk? (and disable it when
shipping product by disabling the compile time flag?).
I think feature doing that tends to become stable a lot quicker.

We remove experimental features frequently. The compile time flags make
it a lot easier to clean up.

Benjamin


More information about the webkit-dev mailing list