[webkit-dev] Do we need ENABLE(SQL_DATABASE) guards?

[Benjamin Poulain]

Nice. Thanks for the links.

We should do the same, at least add a #ifdef for the worker support. It 
is a step in the right direction.

On 12/15/14 4:54 PM, TAMURA, Kent wrote:
> Yes.
>
> openDatabase on WorkerGlobalScope:
> https://www.chromestatus.com/metrics/feature/timeline/popularity/313
>
> openDatabaseSync on WorkerGlobalScope:
> https://www.chromestatus.com/metrics/feature/timeline/popularity/314
>
> openDatabase on Window: (We can't remove this yet.)
> https://www.chromestatus.com/metrics/feature/timeline/popularity/10
>
>
> These graph contains a period in which Google Chrome still had Web SQL
> for Workers.  However the usage was almost zero.
>
>
> On Tue, Dec 16, 2014 at 9:43 AM, Benjamin Poulain <benjamin at webkit.org
> <mailto:benjamin at webkit.org>> wrote:
>
>     That's interesting information.
>
>     Did you add usage counters before the removal? Any idea how much
>     usage there is?
>
>     On 12/15/14 4:28 PM, TAMURA, Kent wrote:
>
>         FYI.  We removed Web SQL support for Workers in Blink, and already
>         shipped the removal in Google Chrome stable channel.  The
>         removal made
>         the code much simpler because we don't need synchronous-version
>         classes.
>
>
>         On Sat, Dec 6, 2014 at 9:13 AM, Benjamin Poulain
>         <benjamin at webkit.org <mailto:benjamin at webkit.org>
>         <mailto:benjamin at webkit.org <mailto:benjamin at webkit.org>>> wrote:
>
>              I hope we will be able to get rid of WebSQL at some point.
>         The guard
>              would be useful for cleanup.
>
>              But given how popular WebSQL is, I don't see us doing that
>         anytime
>              soon. :(
>
>              I am in favor of removing the flag.
>
>              Benjamin
>
>
>              On 12/5/14 6:38 AM, Osztrogonác Csaba wrote:
>
>                  Hi all,
>
>                  it seems ENABLE(SQL_DATABASE) is enabled on all ports,
>                  but there are still ifdef guards for it in 300+ files.
>
>                  Is there anybody shipping WebKit with disabled
>         SQL_DATABASE?
>                  If no, I'd propopse removing these guards.
>
>                  br,
>                  Ossy
>
>                  ___________________________________________________
>                  webkit-dev mailing list
>         webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>         <mailto:webkit-dev at lists.__webkit.org
>         <mailto:webkit-dev at lists.webkit.org>>
>         https://lists.webkit.org/____mailman/listinfo/webkit-dev
>         <https://lists.webkit.org/__mailman/listinfo/webkit-dev>
>                  <https://lists.webkit.org/__mailman/listinfo/webkit-dev
>         <https://lists.webkit.org/mailman/listinfo/webkit-dev>>
>
>
>              ___________________________________________________
>              webkit-dev mailing list
>         webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>         <mailto:webkit-dev at lists.__webkit.org
>         <mailto:webkit-dev at lists.webkit.org>>
>         https://lists.webkit.org/____mailman/listinfo/webkit-dev
>         <https://lists.webkit.org/__mailman/listinfo/webkit-dev>
>              <https://lists.webkit.org/__mailman/listinfo/webkit-dev
>         <https://lists.webkit.org/mailman/listinfo/webkit-dev>>
>
>
>
>         --
>         TAMURA Kent
>         Software Engineer, Google
>
>
>
>
>
> --
> TAMURA Kent
> Software Engineer, Google
>
>