[webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Alexey Proskuryakov ap at webkit.org
Fri Apr 4 13:56:24 PDT 2014

04 апр. 2014 г., в 9:08, Zoltan Horvath <zoltan at webkit.org> написал(а):

>  - I think the best behavior for this case would be to abort the change log creation, if there are errors on the actual code check. (Then you can fix those, and when you rerun prepare-Changelog, it puts the recent things into the change log. [e.g. you've got a lower/uppercase function naming warning, and the function name appears in the change log])

It's very common for style checker to report false positives. Many of the style warnings I get are either outright incorrect, or ask to change formatting of existing code, which is not always appropriate.

So, refusing to create a ChangeLog unless I disable the style checker would be quite annoying.

- WBR, Alexey Proskuryakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20140404/1df504a7/attachment.html>

More information about the webkit-dev mailing list