[webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

Brendan Long self at brendanlong.com
Fri Apr 4 07:27:46 PDT 2014


Doesn't 'webkit-patch upload' already do that?

On 04/04/2014 02:14 AM, James Craig wrote:
> I sometimes forget to run the check-webkit-style script before uploading patches, so I put a patch up for review that adds a --style and --no-style flags to prepare-Changelog and svn-create-patch. Alexey suggested I make it the default, which I've done for prepare-Changelog, but not in svn-create-patch due to cross-references that cause a loop when it't the default. (I just added the --style flag to my local bash alias.)
>
> Any concerns or suggestions? Thanks.
>
> http://webkit.org/b/131115
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev



More information about the webkit-dev mailing list