[webkit-dev] Type cast by using toFoo()

Gyuyoung Kim gyuyoung.kim at webkit.org
Mon Sep 30 22:52:48 PDT 2013

My plan is to show style error when submitted patch doesn't use toFoo()
though toFoo exists. This idea was originated from blink commit. However,
it was reverted because of some regression.


If my understanding is correct, the toFoo() style checker checks if there
is toFoo() in a class. If uploaded patch uses static_cast<> instead of
toFoo() though there is toFoo(), style checker will generate style error.

Anyway, I think I need to investigate the commit and consider the idea


On Tue, Oct 1, 2013 at 3:20 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Mon, Sep 30, 2013 at 10:52 AM, Yong Li <yong.li.webkit at outlook.com>wrote:
>> Bottom line is turning on RTTI in debug build?
> Style checker analyzes the code statically.  It's nothing to do with
> runtime assertions.  If that wasn't clear enough, style check happens
> before WebKit is ever built.
> - R. Niwa
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20131001/2bbab78a/attachment.html>

More information about the webkit-dev mailing list