[webkit-dev] [Possibly spoofed] Re: Loading and unloading webkit, threading, AtomicString and crashes

[Van Den Berghe, Vincent]

Hello Brent,

Thanks for doing this. It was already darkness here, and I was sleeping.

Vincent

From: Brent Fulgham [mailto:bfulgham at gmail.com]
Sent: Monday, September 16, 2013 5:00 AM
To: Alexey Proskuryakov
Cc: Van Den Berghe, Vincent; webkit-dev at lists.webkit.org
Subject: [Possibly spoofed] Re: [webkit-dev] Loading and unloading webkit, threading, AtomicString and crashes

I realized it was easier to light a candle than curse the darkness, so I converted the original e-mail to a bug.  Let's move discussion of this issue there:

https://bugs.webkit.org/show_bug.cgi?id=121407

Thanks!

-Brent

On Sep 15, 2013, at 10:52 AM, Alexey Proskuryakov <ap at webkit.org<mailto:ap at webkit.org>> wrote:



15.09.2013, в 08:53, "Van Den Berghe, Vincent" <Vincent.VanDenBerghe at bvdinfo.com<mailto:Vincent.VanDenBerghe at bvdinfo.com>> написал(а):


    static AtomicString lucidaStr("Lucida Grande");

It is a mistake to use static objects with destructors in WebKit - we don't want to waste time destructing them at process termination time. To fix this issue, DEFINE_STATIC_LOCAL should be used.

In a somewhat dated checkout I have on this machine, I found 5 instances of "static AtomicString" in WebCore, and none in WebKit/win.

- WBR, Alexey Proskuryakov

_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org<mailto:webkit-dev at lists.webkit.org>
https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130916/6b6dba17/attachment.html>