[webkit-dev] Is Nix/GTK/EFL really using applyPageScaleFactorInCompositor?

Gwang-Yoon Hwang ryumiel at company100.net
Sun Sep 15 18:45:19 PDT 2013


Hello, Benjamin.

In coordinated graphics, applyPageScaleFactorInComposit**or is intended to
prevent relayout occurred by scale factor changes.

However, as you mentioned, coordinated graphics uses setUseFixedLayout as a
flag to apply optimization for mobile, I agree that
applyPageScaleFactorInComposit**or and other things should be refactor.

I'm currently working on refactor coordinated graphics, so i'll take care
about it.



On Fri, Sep 13, 2013 at 1:59 PM, Benjamin Poulain <benjamin at webkit.org>wrote:

> Hi WebKit,
>
> There are remains of applyPageScaleFactorInComposit**or here and there in
> the code and it is not clear to me if it is correct or not.
>
> The hack was introduced specifically for chromium (
> https://bugs.webkit.org/show_**bug.cgi?id=107424<https://bugs.webkit.org/show_bug.cgi?id=107424>)
> and most of the code has already been cleaned.
> I could only find one place where that setting is set:
> WebPage::setUseFixedLayout() with USE(COORDINATED_GRAPHICS). This was added
> here: https://bugs.webkit.org/show_**bug.cgi?id=105978<https://bugs.webkit.org/show_bug.cgi?id=105978>
>
> It is really this settings is related to fixedLayout.
> The code of applyDeviceScaleFactorInCompos**itor creates subtle
> differences in the scale of layers. It would be good if someone who works
> on coordinated graphics could check if this behavior is intended.
>
> Benjamin
> ______________________________**_________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/**mailman/listinfo/webkit-dev<https://lists.webkit.org/mailman/listinfo/webkit-dev>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130916/a55c4ce9/attachment.html>


More information about the webkit-dev mailing list