[webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

Allan Sandfeld Jensen kde at carewolf.com
Thu Sep 12 17:15:37 PDT 2013


On Friday 13 September 2013, Benjamin Poulain wrote:
> On 9/12/13 4:48 PM, Ryosuke Niwa wrote:
> > On Thu, Sep 12, 2013 at 4:45 PM, Allan Sandfeld Jensen
> > 
> > <kde at carewolf.com <mailto:kde at carewolf.com>> wrote:
> >     Don't worry we are still here, just in fewer numbers, and with
> >     fewer things to
> >     support.
> >     
> >     I would prefer to keep the warning, it is quite useful at times,
> >     and when it
> >     isn't you just add a default case with an ASSERT_NOT_REACHED()
> > 
> > And that's an added maintenance cost everyone has to pay.
> > 
> > Given that other ports such as Mac & GTK+ have this warning enabled
> > and we have reliable EWS bots, I don't see why we want to keep this
> > warning on ports that use old versions of gcc that force us to add
> > useless code.
> 
> I agree with you on this, I had the problem several times.
> 
> I think the best would be to update the Qt bots. If that cannot be done,
> it would be best to disable the warning until the bots can be upgraded.
> 
Do we know what GCC versions are bad, or at least at what point they become 
good enough on this warning? (we tend to get more warnings not fewer with gcc 
4.8).

`Allan


More information about the webkit-dev mailing list