[webkit-dev] Please install shellwords on the bots

[Brent Fulgham]

It appears that Shellwords is part of the standard Ruby install we use on the Cygwin-based Windows systems.

-Brent

On Oct 6, 2013, at 2:06 PM, Filip Pizlo <fpizlo at apple.com> wrote:

> 
> On Oct 6, 2013, at 2:00 PM, Benjamin Poulain <benjamin at webkit.org> wrote:
> 
>> On 10/6/13, 1:54 PM, Filip Pizlo wrote:
>>> This bug: https://bugs.webkit.org/show_bug.cgi?id=120696
>>> 
>>> Is for making run-javascriptcore-tests run all of the tests in
>>> parallel and in a way that is aware of our multiple tiers.  It vastly
>>> improves JSC test coverage.
>>> 
>>> Right now, the script will refuse to do anything if your machine
>>> doesn't have the Ruby shellwords package installed.  Eventually I'll
>>> change that to make it just fail.
>>> 
>>> Please install shellwords on the bots so that this script can work.
>>> 
>>> (And no, I don't see an easy alternative to using shellwords for this
>>> testing infrastructure.  It would take a lot more code if we didn't
>>> want to use shellwords.  So, you should install shellwords to run
>>> javascriptcore tests.  It's already installed by default on a lot of
>>> OS's.)
>>> 
>>> I'll be landing this patch soon.  We need the test coverage.
>> 
>> Could run-javascriptcore-tests just install shellwords when it is missing?
> 
> Probably.
> 
>> 
>> There is a precedent of this, webkit-patch downloads every missing
>> packages, making it easy to use without installing the dependencies.
> 
> In the case of shellwords, the majority of WebKit developers will already have it.  It’s part of the Ruby standard library as of version 2.
> 
>> 
>> Benjamin
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20131007/46513ff6/attachment.html>