[webkit-dev] Please install shellwords on the bots

Benjamin Poulain benjamin at webkit.org
Sun Oct 6 14:00:31 PDT 2013


On 10/6/13, 1:54 PM, Filip Pizlo wrote:
> This bug: https://bugs.webkit.org/show_bug.cgi?id=120696
> 
> Is for making run-javascriptcore-tests run all of the tests in
> parallel and in a way that is aware of our multiple tiers.  It vastly
> improves JSC test coverage.
> 
> Right now, the script will refuse to do anything if your machine
> doesn't have the Ruby shellwords package installed.  Eventually I'll
> change that to make it just fail.
> 
> Please install shellwords on the bots so that this script can work.
> 
> (And no, I don't see an easy alternative to using shellwords for this
> testing infrastructure.  It would take a lot more code if we didn't
> want to use shellwords.  So, you should install shellwords to run
> javascriptcore tests.  It's already installed by default on a lot of
> OS's.)
> 
> I'll be landing this patch soon.  We need the test coverage.

Could run-javascriptcore-tests just install shellwords when it is missing?

There is a precedent of this, webkit-patch downloads every missing
packages, making it easy to use without installing the dependencies.

Benjamin



More information about the webkit-dev mailing list