[webkit-dev] Moving WebCore/accessibility code into WebCore/platform/

Mario Sanchez Prada mario.prada at samsung.com
Wed May 22 02:06:06 PDT 2013

Hi Maciej,

> I think the main problem with this change is that the
> current WebCore/accessibility code has lots of knowledge
> of the DOM and render tree. Making WebCore/platform
> depend on these Web-specific concepts is a layering
> violation - imagine how it would work if it was a
> top-level directory Platform that was a peer of WebCore,
> and built before it without access to its headers. 
> That is logically how it should operate.

That's absolutely right. When I sent the email I was thinking more of the
platform specific nature of the accessibility layer and its adaptation to
each port (the wrappers), but it's true that the relationship with those
other trees is so tight that moving it into platform (as it is now) would be
a problem.

> If the accessibility code could be redesigned to have
> a good abstraction between the parts that are tightly
> tied to Web-specific classes and concepts, and the part
> that is platform-specific, then the second part could
> be moved to WebCore/platform. A refactoring like that
> could be a good improvement, but is likely hard to do.

Agreed on this too. 

Thanks for the feedback,

More information about the webkit-dev mailing list