[webkit-dev] Moving WebCore/accessibility code into WebCore/platform/
weinig at apple.com
Tue May 21 10:58:07 PDT 2013
On May 21, 2013, at 10:56 AM, Darin Adler <darin at apple.com> wrote:
> On May 21, 2013, at 10:42 AM, Sam Weinig <weinig at apple.com> wrote:
>> On May 21, 2013, at 8:15 AM, Darin Adler <darin at apple.com> wrote:
>>>> Of course, we could always add an exception to the style checker
>>> The style checker rule is wrong and should be removed. It’s better to use a platform abstraction, but a platform #ifdef is also OK.
>> This was something we discussed during the contributors meeting. The premise was that we should aim for having no PLATFORM() #ifdefs in non-Platform and and should instead use other macros that are more descriptive. I like that rule, but if isn't really possible, we should probably remove the check.
> It’s an interesting principle, but I think too far from reality right now.
> And it leads to crazy things like the Clipboard in the dom directory with per-platform subclasses in the platform directory.
> — Darin
Fair enough. I'll talk to Jessie about removing it, and maybe we can revisit it in the future.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev