[webkit-dev] Turning CSS Variables Off

Benjamin Poulain benjamin at webkit.org
Mon May 13 17:23:10 PDT 2013


On Mon, May 13, 2013 at 3:36 PM, Bear Travis <betravis at adobe.com> wrote:

> There has already been some discussion about removing the CSS Variables
> code [1], and some early looks at what removing it from the code base would
> look like [2].
> Currently, the EFL and GTK ports enable CSS Variables in the
> Source/cmake/Options[Efl/GTK].cmake files. I am proposing turning them off
> and excluding the CSS Variables tests until someone steps up to maintain
> the feature, or the feature is removed.
>
> I am proposing this as the cost of leaving the feature enabled is
> non-zero. The feature is incomplete and bugs are going to surface. Today I
> had a test regression with a css variables + exclusions test because the
> test and behavior were incorrectly implemented [3]. This regression turned
> up when it caused the bots to fail, and had to be diagnosed by today's
> gardener, and then forwarded to me to be fixed. I don't think this cost is
> worth it for a feature we are not (at least to my knowledge) planning to
> actively implement.
>

It is better if you remove the feature instead keeping dead code around.


More information about the webkit-dev mailing list