[webkit-dev] Compiling WebKit up to 25% faster in Windows?

[Dirk Pranke]

On Tue, Mar 26, 2013 at 11:47 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Tue, Mar 26, 2013 at 11:42 AM, Jarred Nicholls <jarred at webkit.org>wrote:
>
>> On Tue, Mar 26, 2013 at 2:37 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>
>>> On Tue, Mar 26, 2013 at 11:21 AM, Daniel Bratell <bratell at opera.com>wrote:
>>>
>>>> Is this something that has been talked about in the past, and would you
>>>> be interested in replacing the long list of directories to search for every
>>>> include with paths (relative some good base) directly in the include
>>>> directives?
>>>>
>>>
>>> Using explicit paths to include files has been talked about in the past;
>>> e.g.
>>> https://lists.webkit.org/pipermail/webkit-dev/2011-November/018632.html
>>>
>>> The most convincing counter argument I can remember is that it'll make
>>> refactoring harder because you'll have to update all #include's when you
>>> move headers.
>>>
>>
>> A few tailored scripts make that an easier job.  We're all engineers
>> after all.
>>
>
> We have been talking about this for years, and we even have bugs:
> https://bugs.webkit.org/show_bug.cgi?id=61772
> Given that, I'm somewhat skeptical if we ever get around to it in
> foreseeable future.
>
>
Scripts that update include paths from Source/WebCore/foo.h to
Source/Platform/foo.h are substantially easier than something to modify
XCode projects robustly ;)

If we have consensus that we should just switch to paths relative to Source
(or maybe a couple different options), that would be (IMO) a big win. It
sounds like Daniel & co. have already done the big bang conversion.


On Tue, Mar 26, 2013 at 11:58 AM, Geoffrey Garen <ggaren at apple.com> wrote:

> > In WebKit include directives are without path, and instead the compiler
> is given a very long list of directories to search through. That process
> takes a lot of time in Windows. It must take some time in OSX and in Linux
> too but probably less.
>
> Can we make a first-order improvement just by making sure that paths are
> searched in order of likelihood?
>

That actually sounds harder and more fragile to me than switch to full
paths across the board.

-- Dirk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130326/85545d29/attachment.html>