[webkit-dev] Please don't land patches without rebaselining tests for at least one platform

[Silvia Pfeiffer]

On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak <mjs at apple.com> wrote:
>
>> On Mar 21, 2013, at 5:38 PM, Glenn Adams <glenn at skynav.com> wrote:
>>
>>  On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>
>>> On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams <glenn at skynav.com> wrote:
>>>
>>>>
>>>> On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>>>
>>>>> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams <glenn at skynav.com> wrote:
>>>>>
>>>>>> That's my platform, so I have to manage with it.
>>>>>>
>>>>>
>>>>> I do have a Retina MBP too but I don't use it to work on the rendering
>>>>> engine precisely because of this issue.  It's expected that every
>>>>> contributor has access to a machine where he/she can run layout tests.
>>>>>  Retina MBP is not such a machine.
>>>>>
>>>>
>>>> Well, it's been working for me.
>>>>
>>>
>>> The fact you appears to be contributing patches without appropriate
>>> rebaselines seems to indicate that it's not working for us.
>>>
>>
>> Oh, please point out a case of "without appropriate rebaseline". Please
>> point out in the documentation where "appropriate rebaseline" is defined. I
>> think you are making unwarranted assumptions here. If you can't define or
>> understand a process where I can contribute using a MBP Retina, then I
>> think you are imposing an arbitrary, unwarranted restriction on the
>> community. I have been contributing successfully, ergo, it is working.
>>
>> Many are contributing WebCore layout and rendering patches using a wide
>> variety of platforms, not all of which match your platform assumptions. It
>> is not reasonable to claim they aren't contributing positively or that
>> their contributions don't work.
>>
>>
>> We should definitely make it possible to contribute using a Retina
>> system. Apple's flagship laptops offer Retina displays, and it would be
>> crazy to rule them out as development machines. I'd imagine one day we may
>> want the canonical Mac pixel results to be *only* retina.
>>
>
> Yes, we should but it isn't today.
>
>  Perhaps one possibility is to make it possible to generate non-Retina
>> pixel results on a Retina system. That seems eminently doable to me, unless
>> there's something I am missing.
>>
>
>  Yeah, Alexey and I were talking about this earlier. We need a some way
> to force CAGraphics, etc… to behave as if we're in non-Retina MBP. We
> definitely don't want to check in Retina pixel results.
>

Where can I sign up to make this a higher priority. ;-)

Developing on the Retina MBP is a real joy because of its speed and
beautiful display - it is faster than the old Mac Pro I had. I was bummed
to find out that I couldn't create pixel results on it nor properly run
layout tests. Now I have a separate Linux machine for layout testing.

Silvia.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130322/58c87d17/attachment.html>