[webkit-dev] Please don't land patches without rebaselining tests for at least one platform

Ryosuke Niwa rniwa at webkit.org
Thu Mar 21 17:08:22 PDT 2013

On Thu, Mar 21, 2013 at 5:04 PM, Silvia Pfeiffer <silviapf at chromium.org>wrote:

> On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>  On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams <glenn at skynav.com> wrote:
>>> On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>> In general, I don't recommend people running and relying on layout tests
>>>> on Retina MBP especially if you work on the rendering engine at this time.
>>> That's my platform, so I have to manage with it.
>> I do have a Retina MBP too but I don't use it to work on the rendering
>> engine precisely because of this issue.  It's expected that every
>> contributor has access to a machine where he/she can run layout tests.
>>  Retina MBP is not such a machine.
> Why is that the case? Why can't we start creating pixel test expectation
> for Retina MBPs?

Because run-webkit-tests doesn't support it. We don't even have a way of
whether we're running on Retina MBP or not.

If implemented correctly, "retina" will be a new dimension relative to
platform and WK2. There will be a combinatorial explosion though because
any given platform (e.g. Mountain Lion) could have combinations of WK1/WK2
and Retina/non-Retina.

I have been discussing this matter with my colleagues but we haven't gotten
around to implement it.

- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130321/09bcd977/attachment.html>

More information about the webkit-dev mailing list