[webkit-dev] window.internals abuse

[James Robinson]

On Thu, Mar 14, 2013 at 1:47 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> \On Thu, Mar 14, 2013 at 1:43 PM, James Robinson <jamesr at google.com>wrote:
>
>> The patch in question landed nearly a year ago and was added in order to
>> test functionality that was (at the time) implemented in WebCore.
>>  window.testRunner may have been a better choice, I don't remember what the
>> state of it at the time was.  Nowadays the functionality under test is no
>> longer in WebCore and thus this infrastructure is being removed so I think
>> the question is moot.
>>
>
> Great. Thanks for the follow up. Perhaps we need a wiki page to illustrate
> the use case for testRunner vs. internals?
>
> I don't think many new contributors are aware of the different use cases
> each object has.
>

That sounds great.
http://trac.webkit.org/wiki/Exposing%20WebKit%20internals%20for%20Layout%20Tests
seems
to cover some of this, but it seems a bit dated.

- James


>
> - R. Niwa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130314/3987ef05/attachment.html>