[webkit-dev] window.internals abuse
danakj at chromium.org
Wed Mar 13 10:22:11 PDT 2013
On Wed, Mar 13, 2013 at 1:21 PM, Simon Fraser <simon.fraser at apple.com>wrote:
> On Mar 13, 2013, at 10:15 AM, Dana Jansens <danakj at chromium.org> wrote:
> On Wed, Mar 13, 2013 at 12:42 PM, Simon Fraser <simon.fraser at apple.com>wrote:
>> https://bugs.webkit.org/show_bug.cgi?id=80046 (landed in
>> http://trac.webkit.org/changeset/114081) added
>> internals. setBackgroundBlurOnNode().
>> I consider this to be abuse of the Internals object. As shown by the
>> location of the files (Source/WebCore/*testing*/Internals.*), the
>> Internals interface is intended for testing, not adding API to toggle
>> features in WebCore for non-test code.
> Sorry, but I think this is based on a misunderstanding. That function is
> used for enabling the feature in layout tests in order to verify it is
> working. It is not used in non-test code.
> So why does the feature exist at all?
It can be enabled by UI code via the platform layer directly.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev