[webkit-dev] window.internals abuse

Benjamin Poulain benjamin at webkit.org
Wed Mar 13 10:12:28 PDT 2013


On Wed, Mar 13, 2013 at 10:04 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> Background blur (or background filters in general) are not a web-exposed
>> feature, so it seems odd that Internals has a switch for some
>> non-web-exposed feature that is only implemented by one port. It feels like
>> this was something added for a UI feature in Chromium, in which case
>> Internals isn't an appropriate way to toggle it.
>>
>
> What is the rule of thumb here?  Are you specifically objecting to testing
> features that are not Web-exposed?  e.g. would you object to testing
> features only available in dashboard?
>

In my opinion, anything that is exposed trough APIs is better tested
through TestRunner than Internals.
The methods left on TestRunner should be the ones exposed by at least one
port.

Cheers,
Benjamin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130313/6a2c2a1a/attachment.html>


More information about the webkit-dev mailing list