[webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform

[Arunprasad Rajkumar]

Hi,

Please ignore if it is really out of context.

It would be nice to define a Class by Class
roles/responsibilities/expectations from Platform layer before starting
implementation. May be it is a kind of Class/Function standardization
process :). I agree that currently we have standardized platform specific
interface classes like GraphicsContext, ResourceHandle, ImageFrame,.. but
the issue is each port has its own extensions to those classes to make the
process easier, PSB
class GraphicsContext {
...
#if PLATFORM(QT)
        ShadowBlur* shadowBlur();
#endif
...
#if USE(CAIRO)
        GraphicsContext(cairo_t*);
#endif
..
#if USE(CG)
        void applyStrokePattern();
        void applyFillPattern();
        void drawPath(const Path&);

        void drawNativeImage(NativeImagePtr, const FloatSize& selfSize,
ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect&
srcRect, CompositeOperator = CompositeSourceOver, BlendMode =
BlendModeNormal, ImageOrientation = DefaultImageOrientation);

        // Allow font smoothing (LCD antialiasing). Not part of the
graphics state.
        void setAllowsFontSmoothing(bool);

        void setIsCALayerContext(bool);
        bool isCALayerContext() const;

        void setIsAcceleratedContext(bool);
#endif

};

How we are going to address these?. After this work whether we have all
these defines?

Kind Regards,
Arun

On 1 March 2013 21:50, Žan Doberšek <zandobersek at gmail.com> wrote:

> On Fri, Mar 1, 2013 at 12:43 PM, Jesus Sanchez-Palencia <jesus at webkit.org>wrote:
>
>> Hi,
>>
>> 2013/2/28 Darin Adler <darin at apple.com>:
>> > To do this, we need to eliminate dependencies from the platform
>> directory to the rest of WebCore.
>> >
>> > At this time, we are far from that. Many dependencies on the DOM and
>> other such things have crept into the platform directory.
>>
>> I would be happy to help fixing this, Darin. Are the bugs blocking
>> https://bugs.webkit.org/show_bug.cgi?id=21354 a good-enough to start
>> list or is there something more urgent?
>>
>
> Violations reported by those bugs are most likely still valid. There are
> of course probably other existing violations that haven't been reported yet.
>
> -Z
>
>
>>
>> Cheers,
>> jesus
>>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>


-- 
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130301/b88423fe/attachment.html>