[webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

[Mario Sanchez Prada]

Hi Kyounga,

> [...]
> First, I filed up my new patch based on the latest webkit without new
feature-name even though this discussion wasn't concluded. 

I did not find any patch in bugzilla for bug 66027 newer than the one from
Jan 2012 when I started doing the experiments, so that's why I came up with
my own rebased version. Now I see you posted a newer version already, thanks
for doing that.

> If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS,
I'll make a new patch. 

That's probably a good idea but first we need to clarify whether this might
fit or not integrated in webkit.org. And in order to do that, as Benjamin
mentioned, we need to have at least one port using and maintaining that
feature, so that's why I proposed that we could help doing that work for the
WebKitGTK+ port, besides helping with the development of your patch, if you
wish.

> If this feature is widely used in TV industry and is included in next
CSS4,
> it is not bad implementing this feature in Webkit. Isn't it? 

I agree with you, but for the feature to make it to upstream WebKit some
more things are needed, as it was explained previously in this thread.

> And then, should I mark the 66027 bug as "Reopended" to review it?

I would say so, but before asking for review over it, and besides the
ongoing discussion here, I believe the patch needs still some changes in
addition to being rebased, such as adding tests to it and probably
re-writting the part based on the now called DeprecatedStyleBuilder which,
according to r148363, should not be used to add new properties since a while
ago.

Thanks for your reply,
Mario

[1] http://trac.webkit.org/changeset/148363

> -Kyounga
>
> > 2013/7/25 Mario Sanchez Prada <mario.prada at samsung.com>
> > Hi,
> >
> > For the sake of completeness, I'd like to mention that this feature is
also
> > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale
from
> > Opera already pointed out in a recent discussion[1].
> >
> > That, together with what it was mentioned about the SmartTV Alliance
using
> > it, means that pretty much the whole TV world is relying quite a bit on
this
> > thing nowadays, so it would be great if we could have it integrated and
> > supported upstream.
> >
> > That being said, we at the Samsung would be happy to support this
feature
> > actively in WebKit, both by helping with the patch that's already in
> > Bugzilla [2] *and* maintaining it in at least one port. Should that be
the
> > case, the obvious choice for us would be the WebKitGTK port, since
that's
> > what we currently have on our TVs.
> >
> > Problem is that the patch in [2] is quite old already (Jan 2012), so it
> > would be awesome if Kyounga Ra attached a newer version of it, since
that
> > one depends on some parts that are now deprecated or simply refactored
in
> > some way, as I could check today while experimenting with it on top of
> > latest WebKit [3].
> >
> > Last, regarding to tests, just to mention that Opera has recently
submitted
> > tests for this feature (see [4]). This would be IMHO another good point
to
> > keep in mind here, since we could import them in WebKit too.
> >
> > What do you think?
> > Mario
> >
> > [1] http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html
> > [2] https://bugs.webkit.org/show_bug.cgi?id=66027
> > [3]
https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5
ea1672
> > [4]
http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html
>
> > -----Original Message-----
> > From: webkit-dev-bounces at lists.webkit.org [mailto:webkit-dev-
> > bounces at lists.webkit.org] On Behalf Of Danilo Cesar Lemes de Paula
> > Sent: 24 July 2013 14:52
> > To: webkit-dev at lists.webkit.org
> > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to
> > WebCore.
> >
> > On 07/23/2013 09:26 PM, Kyounga Ra wrote:
> > > -Which browsers are shipping the feature?
> > > -Which browsers are planning to ship the feature?
> > > A) other major browsers? opera presto
> > >     also Webkit-based TV browsers support it.
> > >
> > > -Is it a mature standard (or an amazing feature) that one of the
> > > WebKit ports wants to maintain?
> > > A) not matured yet. but these properties are widely used by the TV
> > > industry.
> > >      TV industry people like me want to maintain.
> > >
> >
> > nav-[dir] is a required part of the SmartTV Alliance spec, so it's
> > probably being used by Phillips, LG and Toshiba TVs.
> >
> > Danilo Cesar
> >
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev


_______________________________________________
webkit-dev mailing list
webkit-dev at lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev