[webkit-dev] Remove CSS_IMAGE_ORIENTATION Feature Guard

Gyuyoung Kim gyuyoung.kim at webkit.org
Tue Jul 2 18:00:54 PDT 2013


Hi Brent,

Sorry for no activity on this. This work was pushed back on the my priority
list. Thus, I agree to remove this feature if nobody(including me) submits
meaningful patch until July 17th.

Gyuyoung.


On Wed, Jul 3, 2013 at 3:05 AM, Brent Fulgham <bfulgham at apple.com> wrote:

> Hi Everyone,
>
> I haven't seen any action on
> https://bugs.webkit.org/show_bug.cgi?id=116555 (or
> https://bugs.webkit.org/show_bug.cgi?id=92330) in the past month.
>
> I'd like to remove this logic unless there is some activity here.  We can
> always add it back in from SVN history if someone does want to work on it.
>
> I'll submit a patch to remove this code on July 17th unless something
> changes.
>
> Thanks,
>
> -Brent
>
>
>
> On Jun 4, 2013, at 10:15 PM, Gyuyoung Kim wrote:
>
> Hi,
>
> I'm interested in this feature. So, I took Bug 92330 over. Though I
> rebased the feature according to review comments, this feature doesn't work
> yet. So, I have investigated why it doesn't work. However, unfortunately, I
> need to have time a little further. If there is no big reason this patch
> should be removed, I'd like to support this feature.
>
> Gyuyoung.
>  On Jun 5, 2013 9:45 AM, "Mike Lawther" <mikelawther at google.com> wrote:
>
>> Fwiw, the original author is no longer working on Blink, and the code has
>> been removed from there.
>>
>>     mike
>> On Jun 5, 2013 1:24 AM, "Brent Fulgham" <bfulgham at apple.com> wrote:
>>
>>> We have code in WebKit that is protected by the
>>> ENABLE(CSS_IMAGE_ORIENTATION) guard, but no active WebKit ports seem to
>>> enable this feature.
>>>
>>> Is anyone currently working on (or planning to work on) this feature?
>>>
>>> Since this CSS feature is currently in an early draft form, and is
>>> likely to change, we may not want to retain this dead code as it will most
>>> likely become obsolete very quickly.
>>>
>>> If no one wants to claim ownership of this feature in the next few days,
>>> I will submit a patch to remove the dead code.
>>>
>>> Thanks,
>>>
>>> -Brent
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130703/51239e36/attachment.html>


More information about the webkit-dev mailing list