No subject
Mon Jan 28 08:41:14 PST 2013
One downside though is that, if you're composing a ChangeLog more manually, it's more awkward to construct the new-style URL since you can't just copy from the URL field.
- Maciej
On Aug 21, 2013, at 2:25 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> Hi,
>
> I have noticed that the change log format has recently been changed. Unfortunately, this didn't work well with all webkitpy tools we have, and has been rolled out in http://trac.webkit.org/changeset/154406.
>
> I kindly ask you to manually edit your patch to use the old format before landing your patch for now.
>
> To clarify, the old multi-line format looks like:
>
> 2013-08-13 Ryosuke Niwa <rniwa at webkit.org>
>
> REGRESSION(r150187): Safari fails to render allrecipe.com comment popups
> https://bugs.webkit.org/show_bug.cgi?id=119780
>
> Reviewed by Benjamin Poulain.
>
> while new single-line format looked like:
>
> 2013-08-18 Ryosuke Niwa <rniwa at webkit.org>
>
> <https://webkit.org/b/119917> Pasting multiple lines into a textarea can introduce extra new lines
>
> Reviewed by Darin Adler.
>
> Separately, I'd like to know whether people liked the new format and it's worth my time making webkitpy adopt the new format.
>
> I personally didn't like the new single-line format because it made the first line of each change log too long. I'm also not a big fun of wrapping URLs in angle brackets. It's also unclear to me what should happen when there are multiple Bugzilla URLs to list.
>
> But I hear the new format made git log --oneline much more readable so I can be convinced although I don't intend to use git for WebKit development in the foreseeable future myself.
>
> - R. Niwa
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
--Boundary_(ID_64yVVkZCvaB8mQJMFFdT8A)
Content-type: text/html; CHARSET=US-ASCII
Content-transfer-encoding: quoted-printable
<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html =
charset=3Diso-8859-1"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: =
after-white-space;"><div><br></div><div>=46rom the new format, I like =
the shorter bug URL and the angle brackets, but I don't care much either =
way about putting the bug URL and title on the same =
line.</div><div><br></div><div>One downside though is that, if you're =
composing a ChangeLog more manually, it's more awkward to construct the =
new-style URL since you can't just copy from the URL =
field.</div><div><br></div><div> - =
Maciej</div><div><br></div><div><div>On Aug 21, 2013, at 2:25 PM, =
Ryosuke Niwa <<a =
href=3D"mailto:rniwa at webkit.org">rniwa at webkit.org</a>> =
wrote:</div><br class=3D"Apple-interchange-newline"><blockquote =
type=3D"cite"><div dir=3D"ltr"><div class=3D"gmail_extra"><div =
class=3D"gmail_quote">On Wed, Aug 21, 2013 at 2:04 PM, Ryosuke Niwa =
<span dir=3D"ltr"><<a href=3D"mailto:rniwa at webkit.org" =
target=3D"_blank">rniwa at webkit.org</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px =
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left=
-style:solid;padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>I =
have noticed that the change log format has recently been changed. =
Unfortunately, this didn't work well with all webkitpy tools we =
have, and has been rolled out in <a =
href=3D"http://trac.webkit.org/changeset/154406" =
target=3D"_blank">http://trac.webkit.org/changeset/154406</a>.</div>
<div><br></div><div><b>I kindly ask you to manually edit your patch to =
use the old format before landing your patch for =
now.</b></div></div></blockquote><div><br></div><div style=3D"">To =
clarify, the old multi-line format looks like:</div>
<div style=3D""><div><div><br></div><div>2013-08-13 Ryosuke Niwa =
<<a =
href=3D"mailto:rniwa at webkit.org">rniwa at webkit.org</a>></div><div><br></=
div><div> REGRESSION(r150187): Safari fails =
to render <a href=3D"http://allrecipe.com/">allrecipe.com</a> comment =
popups</div>
<div> <a =
href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D119780">https://bugs.web=
kit.org/show_bug.cgi?id=3D119780</a></div><div><br></div><div> =
Reviewed by Benjamin =
Poulain.</div></div><div><br></div><div style=3D"">
while new single-line format looked like:</div><div =
style=3D""><div><br></div><div>2013-08-18 Ryosuke Niwa =
<<a =
href=3D"mailto:rniwa at webkit.org">rniwa at webkit.org</a>></div><div><br></=
div><div> <<a =
href=3D"https://webkit.org/b/119917">https://webkit.org/b/119917</a>> =
Pasting multiple lines into a textarea can introduce extra new =
lines</div>
<div><br></div><div> Reviewed by Darin =
Adler.</div></div></div><div><br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px =
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left=
-style:solid;padding-left:1ex">
<div dir=3D"ltr"><div></div><div>Separately, I'd like to know whether =
people liked the new format and it's worth my time making webkitpy adopt =
the new format.</div><div>
<br></div><div>I personally didn't like the <b>new single-line</b> =
format because it made the first line of each change log too long. =
I'm also not a big fun of wrapping URLs in angle brackets. =
It's also unclear to me what should happen when there are multiple =
Bugzilla URLs to list.</div>
<div><br></div><div>But I hear the new format made <font face=3D"courier =
new, monospace">git log --oneline</font> much more readable so I =
can be convinced although I don't intend to use git for WebKit =
development in the foreseeable future myself.</div>
<div><br></div><div><div>- R. Niwa</div><div><br></div>
</div></div>
</blockquote></div><br></div></div>
_______________________________________________<br>webkit-dev mailing =
list<br><a =
href=3D"mailto:webkit-dev at lists.webkit.org">webkit-dev at lists.webkit.org</a=
><br>https://lists.webkit.org/mailman/listinfo/webkit-dev<br></blockquote>=
</div><br></body></html>=
--Boundary_(ID_64yVVkZCvaB8mQJMFFdT8A)--
More information about the webkit-dev
mailing list