[webkit-dev] Breaking other ports

Adam Barth abarth at webkit.org
Wed Jan 30 00:21:28 PST 2013


On Tue, Jan 29, 2013 at 11:58 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> I agree that the regression should be fixed. But before we discuss that...
>
> I am puzzled by the apparent stance of "Alexey must immediately fix this
> himself or we must revert immediately". That's not the standard we have
> applied in the past to changes that appear generally correct but end up
> breaking the UI of a client of a specific port.

No one said "Alexey must immediately fix this himself or we must
revert immediately."  Here's what I said:

"If you cannot address the issue immediately, please let me know so
that I can take further action."

Further actions might include me fixing the issue myself.  I hadn't
figured that out yet.  I just needed an answer quickly so that I could
make sure we resolved this issue in the appropriate time frame.

> To me this example seems pretty parallel to the situation
> <https://bugs.webkit.org/show_bug.cgi?id=108214>. Can anyone explain to me
> why 108214 is being approached so much more aggressively than 52988.

Honestly, it's because you've changed the ground rules for
contributing to WebKit such that it's now ok to break other ports in
some situations.  When Alexey wrote:

"The fact that you chose to do an obvious hack instead does not make
it others' responsibility to support it."

I interpreted that to mean he felt justified in extending those ground
rules to parts of WebCore that don't live up to his personal
engineering standards.  I wanted to be clear that I view that as
unacceptable.

Adam


More information about the webkit-dev mailing list