[webkit-dev] EWS commenting about ancient patches

[Adam Barth]

Maybe we shouldn't bother feeding the bots patches that are over a
certain age (perhaps a week)?

Adam


On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel <eric at webkit.org> wrote:
> I believe the queue was actually cleared when they were brought
> online.  As Ossy notes, this is "expected behavior".
>
> Every time the feeder queue boots up (which is every 2 hours), it
> sends *all* patches marked for review to queues.webkit.org.
>
> queues.webkit.org makes sure that each individual EWS queue has either
> has a result for each patch, or adds it to each individual queue.
>
> Since there are some ancient patches still marked r?, new queues will
> process ancient patches. :)
>
> (The feeder-queue is then smart enough to keep an in-memory list of
> what it's sent to queues.webkit.org, so it only send incremental lists
> until it restarts itself again in 2 hours.)
>
> -eric
>
> On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier
>> than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy
>> points out, Mac WK2 EWS bots have caught up with patches so this shouldn't
>> be a problem in the future.
>>
>> - R. Niwa
>>
>>
>> On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
>>>
>>>
>>> On several occasions over the last few days, I noticed EWS commenting in
>>> bugs that didn't have any recent activity, e.g.
>>> <https://bugs.webkit.org/show_bug.cgi?id=87527>.
>>>
>>> Is EWS picking ancient patches, or is it posting comments to wrong bugs?
>>>
>>> - WBR, Alexey Proskuryakov
>>>
>>> _______________________________________________
>>> webkit-dev mailing list
>>> webkit-dev at lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>>
>>
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev