[webkit-dev] Recommended commit procedure for large EFL rebaseline?

Adam Barth abarth at webkit.org
Mon Jan 14 09:29:06 PST 2013

On Mon, Jan 14, 2013 at 8:39 AM, Dominik Röttsches
<dominik.rottsches at intel.com> wrote:
> when we land https://bugs.webkit.org/show_bug.cgi?id=106774
> we'll have to do a large rebaseline of EFL results. (subpixel and FreeType
> related change)
> Now, for landing, what we had in mind is, (optionally) take our bots
> offline, 1) land the actual patch, 2) then manually land the new baselines.
> Then restart the bots.

I probably wouldn't take your bots offline.  Instead, I would add the
tests to TestExpectations so that the bots expect them to fail.  As
you land new baselines, you can remove the tests for TestExpectations.
 That way you'll be able to incrementally check your work.

> Regarding step 2) there: Would you recommend to land the rebaselines in
> smaller chunks or in one big SVN commit? If in chunks - what sizes work
> well?

Generally it's a good idea to land the baselines in chunks.  If you're
landing image baselines, I'd probably try chunks between 100 and 500
baselines.  If you're landing text baselines, it's less important to
use chunks because they are much smaller.


More information about the webkit-dev mailing list