[webkit-dev] commit-queue and JSC/WK2 specific changes

Ryosuke Niwa rniwa at webkit.org
Thu Jan 10 21:22:03 PST 2013

Hi all,

As you might all know, the commit-queue uses chromium linux port.
Consequently, any JavaScriptCore and WebKit2 specific changes (and any
non-Chromium port specific changes) are never tested. Commit-queue doesn't
even detect whether it builds or not.

This is a source of confusion because many (new) contributors appear to
mistakenly think that commit-queue ensures that the patch builds & passes
tests on all platforms yet commit-queue doesn't wait until EWS bots process
a patch before landing it. As a result, I've seen quite a few people
landing patches that break JSC/WK2 via commit-queue.

My initial proposal was to make commit-queue wait until EWS bots catch up
when landing a port specific or JSC/WK2 specific changes. However, Adam
thinks that's a bad idea (webkit.org/b/74776) because EWS bots are only
advisory and waiting for EWS bots slows things down.

Is this a problem worth finding a solution? If so, do you have any

- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130110/e0ebb6fb/attachment.html>

More information about the webkit-dev mailing list